Follow the guidelines detailed in the appropriate section below. As a general rule of thumb, provide as much information as possible when submitting issues.
Title should be a short, descriptive summary of the bug
Include the Python and ipwhois versions affected
Provide a context (with code example) in the description of your issue. What are you attempting to do?
Include the full obfuscated output. Make sure to set DEBUG logging:
import logging LOG_FORMAT = ('[%(asctime)s] [%(levelname)s] [%(filename)s:%(lineno)s] ' '[%(funcName)s()] %(message)s') logging.basicConfig(level=logging.DEBUG, format=LOG_FORMAT)
Include sources of information with links or screenshots
Do you have a suggestion on how to fix the bug?
- Title should be a short, descriptive summary of the feature requested
- Provide use case examples
- Include sources of information with links or screenshots
- Do you have a suggestion on how to implement the feature?
You may have noticed that Travis CI tests are taking longer to complete. This is due to the enabling of online lookup tests (network tests in the ipwhois/tests/online directory).
When running local tests, you may include these tests by adding the –include=online flag to your nosetests command.
nosetests -v -w ipwhois --include=online --exclude=stress --with-coverage --cover-package=ipwhois
What to include¶
Aside from the core code changes, it is helpful to provide the following (where applicable):
- Unit tests
- Sphinx configuration changes in /docs
- Requirements (python2.txt, python3.txt, docs/requirements.txt)
Title should be a short, descriptive summary of the changes
Follow PEP 8 where possible.
Follow the Google docstring style guide for comments
Must be compatible with Python 2.6, 2.7, and 3.3+
Break out reusable code to functions
Make your code easy to read and comment where necessary
Reference the GitHub issue number in the description (e.g., Issue #01)
When running nosetests, make sure to add the following arguments:
--verbosity=3 --nologcapture --include=online --cover-erase
If you would like to exclude the aggressive online stress tests, add to the above: